Skip to content

Correct a path to cl.cfg file #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Correct a path to cl.cfg file #2431

merged 2 commits into from
Apr 30, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 29, 2025

The location of cl.cfg file created by installing intel-opencl-rt conda package was changed few releases back from %CONDA_PREFIX%\Library\lib\cl.cfg to %CONDA_PREFIX%\Library\bin\cl.cfg.
The file was still created at Library\lib\cl.cfg by intel-opencl-rt-post-link.bat script but with empty content.

The PR updates public CI to rely on correct path to cl.cfg configuration file.
The issue with intel-opencl-rt-post-link.bat script has to be updated by separate change in the compiler repo.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Apr 29, 2025
Copy link
Contributor

github-actions bot commented Apr 29, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.271%. remained the same
when pulling 08241a9 on update-path-to-cl.cfg
into e5ab49b on master.

Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_12 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

@antonwolfy antonwolfy marked this pull request as ready for review April 29, 2025 19:09
@antonwolfy antonwolfy merged commit 4d2be8c into master Apr 30, 2025
68 checks passed
@antonwolfy antonwolfy deleted the update-path-to-cl.cfg branch April 30, 2025 12:40
github-actions bot added a commit that referenced this pull request Apr 30, 2025
The location of `cl.cfg` file created by installing `intel-opencl-rt`
conda package was changed few releases back from
`%CONDA_PREFIX%\Library\lib\cl.cfg` to
`%CONDA_PREFIX%\Library\bin\cl.cfg`.
The file was still created at `Library\lib\cl.cfg` by
`intel-opencl-rt-post-link.bat` script but with empty content.

The PR updates public CI to rely on correct path to `cl.cfg`
configuration file.
The issue with `intel-opencl-rt-post-link.bat` script has to be updated
by separate change in the compiler repo. 4d2be8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants